Replace gene_map_ensgs API requests with native idtype mapping
#189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes Caleydo/tdp_bi_bioinfodb#419 * Replace `gene_map_ensgs` request with native idtype mapping * Remove python DB view * Remove `_id` from typing, as it was not returned by the API and was not used previously
thinkh
added
type: refactor
thinkh
changed the title
gene_map_ensgs API requests with native idtype mapping
oltionchampari
approved these changes
Jun 21, 2022
oltionchampari
deleted the
thinkh/419_replace-gene_map_ensg-with-native-mapping
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires Caleydo/tdp_gene#168
Closes Caleydo/tdp_bi_bioinfodb#419
gene_map_ensgsrequest with native idtype mapping_idfrom typing, as it was not returned by the API and was not used previouslyHow to test
Both refactored ViewUtils functions are used in the Co-Expression plot. After the refactoring it should and does look the same for me as before.