Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make SQLAlchemy pool class configurable + parse JSON in engine settings to dict #226

Merged
merged 2 commits into from
Aug 23, 2023

Conversation

thinkh
Copy link
Member

@thinkh thinkh commented Aug 23, 2023

Related issue: https://github.com/Caleydo/tdp_bi_bioinfodb/issues/1439

Related PR datavisyn/tdp_core#855

Developer Checklist (Definition of Done)

Issue

  • All acceptance criteria from the issue are met
  • Tested in latest Chrome/Firefox

UI/UX/Vis

  • Requires UI/UX/Vis review
    • Reviewer(s) are notified (tag assignees)
    • Review has occurred (link to notes)
    • Feedback is included in this PR
    • Reviewer(s) approve of concept and design

Code

  • Branch is up-to-date with the branch to be merged with, i.e., develop
  • Code is cleaned up and formatted
  • Unit tests are written (frontend/backend if applicable)
  • Integration tests are written (if applicable)

PR

  • Descriptive title for this pull request is provided (will be used for release notes later)
  • Reviewer and assignees are defined
  • Add type label (e.g., bug, feature) to this pull request
  • Add release label (e.g., release: minor) to this PR following semver
  • The PR is connected to the corresponding issue (via Closes #...)
  • Summary of changes is written

Summary of changes

  • make SQLAlchemy pool class configurable by passing a valid SQL Alchemy pool to poolclass
  • parse JSON in engine settings to dict

Screenshots

Additional notes for the reviewer(s)

Thanks for creating this pull request 🤗

@thinkh thinkh added type: feature New feature or request release: minor PR merge results in a new minor version labels Aug 23, 2023
@thinkh thinkh requested a review from puehringer August 23, 2023 10:03
@thinkh thinkh self-assigned this Aug 23, 2023
@puehringer puehringer merged commit ce954f7 into develop Aug 23, 2023
2 checks passed
@puehringer puehringer deleted the thinkh/settigns-parse-engine-json-to-dict branch August 23, 2023 10:09
@thinkh thinkh mentioned this pull request Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: minor PR merge results in a new minor version type: feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants