Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intercom is not compatible with Angular 9 since .forRoot() got deprecated. #101

Open
svelivala opened this issue Apr 13, 2020 · 3 comments

Comments

@svelivala
Copy link

svelivala commented Apr 13, 2020

Versions

  • Angular: 9
  • Angular CLI:9.1.1
  • ng-intercom:8.0.0
  • Node.JS:
  • NPM:

Description

@wbhob
Copy link
Contributor

wbhob commented Apr 13, 2020

We don't claim that this package is compatible with Angular 9 (devDependencies point to v7). Secondly, if this is what you're referring to, forRoot is not deprecated, it just needs a quick modification. Third, please follow the issue template. If you'd like to fix this in a pull request, we'd be more than happy to look at your contribution, and we're looking for more open-source contributors.

@scott-wyatt we can talk about using {providedIn: 'root'} for this, since that's what all the other big Angular packages are transitioning to.

@8tomo8
Copy link

8tomo8 commented Jun 24, 2020

Works perfectly fine for me in Angular 9

@cgbrucezjy
Copy link

for me, intercom boot works, but startTour doesnt work anymore. I notice the fetch call is success, but the iframe is not modified at all, therefor nothing happens.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants