Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove MSBuildSdkExtras workarounds #641

Merged

Conversation

gpetrou
Copy link
Contributor

@gpetrou gpetrou commented Oct 6, 2019

It looks like novotnyllc/MSBuildSdkExtras#173 and novotnyllc/MSBuildSdkExtras#174 have been resolved in newer MSBuildSdkExtras version.

@gpetrou gpetrou changed the title Remove MSBuildSdkExtras workaround Remove MSBuildSdkExtras workarounds Oct 6, 2019
@nigel-sampson nigel-sampson merged commit 8b0512e into Caliburn-Micro:master Oct 7, 2019
@nigel-sampson
Copy link
Contributor

Well it doesn't look to be making the build worse, still looking into the issue. Not sure why we would see a Resource class in Caliburn.Micro.Core or Caliburn.Micro.Platform as neither have any resources.

Looking at src\Caliburn.Micro.Core\obj\Release\monoandroid80\Resource.designer.cs shows an empty file on my machine.

I also can't see anything in the features Resource.designer.cs that's referencing this other class.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants