Firefly-1247: fix GPU.js to create window.GPUX to no longer class with chrome GPU #1384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I tested the firefly build at the provided link, and it works in the latest Chrome! |
loitly
approved these changes
May 15, 2023
| @@ -4,7 +4,8 @@ | |||
|
|
|||
| import {loadScript, getRootURL, getGlobalObj} from '../../util/WebUtil.js'; | |||
|
|
|||
| const GPU_JS_SCRIPT= 'gpu-browser.min-2.15.0.js'; | |||
| // const GPU_JS_SCRIPT= 'gpu-browser.min-2.15.0.js'; | |||
| const GPU_JS_SCRIPT= 'gpu-browser.min-2.15.0-HACK-GPUX.js'; | |||
There was a problem hiding this comment.
If we are naming this file, maybe call it 'patch' instead of hack?
There was a problem hiding this comment.
I called it HACK because it is not a patch from them. I had to edit the file and change the name of of the object consistent with this suggestion: gpujs/gpu.js#820
Maybe a better name is FIX, but I don't want to use patch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Firefly-1247: fix GPU.js to create window.GPUX to no longer class with chrome GPU
gpu-browser.min-2.15.0-HACK-GPUX.jsTest