Silence deprecation warning #1165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adopt new pandas behavior and silence deprecation warning
| @@ -1250,7 +1250,13 @@ def _compute_central_values_of_raw_training_data(self, df, strata=None, name="ba | |||
| return v | |||
|
|
|||
| else: | |||
| described = df.describe(include="all") | |||
| from distutils.version import LooseVersion | |||
| if LooseVersion(pd.__version__) >= '1.1.0': | |||
There was a problem hiding this comment.
One thing is that distutils will be deprecated in Python 3.9/3.10. Might make setuptools a runtime dependency at some point. Haven't been keeping up with this.
|
Nice, thanks for the PR @jseabold! Failing tests are unrelated (and the status quo 🙃) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adopt new pandas behavior and silence deprecation warning. This can be quite noisy in fit if there's a datetime in your DataFrame for pandas >= 1.1.0.
Cf. pandas-dev/pandas#34798