This repository has been archived by the owner on Jun 28, 2024. It is now read-only.
Fix infavorable numpy version in build env #385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arnoldosmium
changed the title
|
Great, thanks! I was having a similar problem with lifelines and I think this work there, too |
|
Generally, I need to update/check the deps on this library, too |
|
Indeed, updating the minimum version requirement of dependencies can avoid some build / user install issues. It could shrink the supported numpy / pandas version range though. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Force updating the cached pip dep environment in travis seems to fix the py3.6 build.
The former cached
numpyversion was too old (1.13.3) compared to other envs in the build matrix (1.15.0)We can add more version pinning if needed, like the pin for
pandas.