-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tidy repo #26
Conversation
@jatkinson1000, there are a couple of unused variables/functions in the MiMA codes e.g. level, error_mesg. Is it ok to remove them or do we want to keep these to keep this code as close as possible to the original implementation? |
No, fine to remove I think. |
Discussed at various stages with @TomMelt, but the general logic behind the changes to real definitions, which are the most substantial changes made in this PR, is:
|
Is the comment I added enough to close #2? |
@ElliottKasoar |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ElliottKasoar. These are some really good improvements.
Hard to say. I am not 100% sure. But I think it would refer to people who maybe use their distro shipped version of python. On Ubuntu, for example, you need to install dev packages separately. Something like |
I certainly encountered an error before installing python-dev on Ubuntu, which I was hoping could be inferred from the comment, but I thought it might be best to keep the comment slightly more general, as I imagine there could be similar requirements on a different distribution/OS. |
Resolves #24
Initial work tidying repository, so far including: