Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Tower Knowledge to include Season max/etc #4

Closed
wants to merge 1 commit into from

Conversation

lostmimic
Copy link

@lostmimic lostmimic commented Jul 23, 2021

Similar changes to what is already in the Valor one.

Will show Can Expend, Total season earns, Maximum permitted, Can still get, session balance.

Verified it on my local client.

image

Similar changes to what is already in the Valor one.
Copy link
Owner

@Canettieri Canettieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, friends.

Thanks for your commit request, but the line 132 and 156 is using the wrong Shadowlands local number. You changed number 18 (Tower Knowledge) by the number 14 (Valor). I think you used the same code and forgot to change this part.

@Canettieri
Copy link
Owner

I've changed Tower Knowledge by my own and it's available in the v7.15.0

Thanks for alerting me this missing feature.

@Canettieri Canettieri closed this Aug 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants