fix(wren-ai-service): disable pass embedding model dim to embedders #579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyyeh
added
module/ai-service
cyyeh
force-pushed
the
fix/ai-service/wo-embedding-model-dim
branch
from
7d44d89
to
08ddb34
Compare
paopa
reviewed
Aug 5, 2024
| @@ -25,6 +25,7 @@ COPY --from=builder ${VIRTUAL_ENV} ${VIRTUAL_ENV} | |||
|
|
|||
| COPY src src | |||
| COPY entrypoint.sh /app/entrypoint.sh | |||
| COPY pyproject.toml pyproject.toml | |||
There was a problem hiding this comment.
it seems been copied in L13, why did we copy it again?
| @@ -25,6 +25,7 @@ aiohttp = {extras = ["speedups"], version = "==3.9.5"} | |||
| ollama-haystack = "==0.0.6" | |||
| langfuse = "==2.35.0" | |||
| ollama = "==0.2.1" | |||
| toml = "==0.10.2" | |||
There was a problem hiding this comment.
what do you think that we move the tomlkit from eval group to main?
| @@ -220,7 +220,6 @@ def get_text_embedder(self): | |||
| return AsyncTextEmbedder( | |||
| api_key=self._embedding_api_key, | |||
| model=self._embedding_model, | |||
| dimensions=self._embedding_model_dim, | |||
There was a problem hiding this comment.
What’s the reason for removing the parameter? Also, what do you think about removing the attribute from the object initializer and related code? It seems like it might clutter the Langfuse trace with unnecessary information.
Comment on lines
+166
to
+175
| embedding_model_dim: int = ( | ||
| int(os.getenv("EMBEDDING_MODEL_DIMENSION")) | ||
| if os.getenv("EMBEDDING_MODEL_DIMENSION") | ||
| else 0 | ||
| ) | ||
| or EMBEDDING_MODEL_DIMENSION, | ||
| ): | ||
| self._url = remove_trailing_slash(url) | ||
| self._embedding_model = embedding_model | ||
| self._embedding_model_dim = embedding_model_dim |
There was a problem hiding this comment.
It doesn’t seem to be used anywhere. I think we can remove it.
Comment on lines
-221
to
-229
| dimensions=self._embedding_model_dim, | ||
| ) | ||
|
|
||
| def get_document_embedder(self): | ||
| return AsyncDocumentEmbedder( | ||
| api_key=self._api_key, | ||
| api_base_url=self._api_base, | ||
| model=self._embedding_model, | ||
| dimensions=self._embedding_model_dim, |
There was a problem hiding this comment.
Same as the comment as Azure OpenAI
paopa
approved these changes
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.