Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] bacon test doesn't let you scroll its output when there are failed tests #137

Closed
miguno opened this issue Jun 3, 2023 · 14 comments · Fixed by #140
Closed

[Bug] bacon test doesn't let you scroll its output when there are failed tests #137

miguno opened this issue Jun 3, 2023 · 14 comments · Fixed by #140

Comments

@miguno
Copy link

miguno commented Jun 3, 2023

When I run bacon test on a test suite with no failed tests, then I can scroll bacon's output (e.g., in a small terminal window):
Screenshot 2023-06-03 at 02 42 09
^ Note the white scrollbar on the right edge of the screenshot

However, whenever there's at least one failed test, then I can no longer scroll the output of bacon test:
Screenshot 2023-06-03 at 02 42 21
^ Note the lack of a scrollbar.

I tried this both with and without a bacon.toml file (the file, if present, was the default one generated with bacon --init).

Environment:

  • macOS
  • WezTerm terminal
  • bacon version 2.8.1
@miguno
Copy link
Author

miguno commented Jun 3, 2023

Possibly related to #133

@miguno miguno changed the title bacon test doesn't let you scroll its output when there are failed tests [Bug] bacon test doesn't let you scroll its output when there are failed tests Jun 3, 2023
@dzfrias
Copy link

dzfrias commented Jun 4, 2023

Possibly related to #133

I'm having this issue too. I don't have nextest set up, though. I upgraded my version of bacon, and this issue started appearing. I'm not sure which release caused it though.

@dzfrias
Copy link

dzfrias commented Jun 4, 2023

I tried uninstalling v2.8.1 and installed v2.8.0 and I'm getting the proper output now. I'm on macOS and using Alacritty.

Entering this into my terminal (not through bacon) returns a status code of 101:

command = [
"cargo", "test", "--color", "always",
"--", "--color", "always", # see https://github.com/Canop/bacon/issues/124
]

@miguno
Copy link
Author

miguno commented Jun 11, 2023

The original bug described in my first comment also happens on Ubuntu in WSL2 on Windows 11.

@joshka
Copy link

joshka commented Jun 17, 2023

+1 macbook m2 / iterm (both with test and nextest)

Canop added a commit that referenced this issue Jun 17, 2023
Fix part of #137

(part because it lets you scroll but this output
should be parsable to start with)
@Canop
Copy link
Owner

Canop commented Jun 17, 2023

This should be fixed by #140 - testers welcome

@miguno
Copy link
Author

miguno commented Jun 18, 2023

@Canop : Thanks for the update! #140 does fix the scrolling issue (when there are failing tests) on my side.

@miguno
Copy link
Author

miguno commented Jun 18, 2023

Addendum: What is still looking wrong to me though is that errors (or warnings) are not shown right at the top of bacon's output. Here's an example of a failed test suite, with bacon 2.9.0-dev:

Screenshot 2023-06-18 at 12 06 41

I would have expected that the error, which is actually shown at the bottom of the output above, would be shown at the top of bacon's output, similar to the screenshot in the README.

@Canop
Copy link
Owner

Canop commented Jun 18, 2023

@miguno It's still not parsed. Can you push your project so that I test?

@miguno
Copy link
Author

miguno commented Jun 18, 2023

Here's an example project: https://github.com/miguno/rust-template

Open https://github.com/miguno/rust-template/blob/main/tests/tests.rs and modify one of the simple tests to make them fail, and then run bacon test.

@Canop
Copy link
Owner

Canop commented Jun 18, 2023

Here's what I get with #140:
image

Are you sure you were using the right version of bacon in your test ?

@miguno
Copy link
Author

miguno commented Jun 18, 2023

Are you sure you were using the right version of bacon in your test ?

Yes, I am sure.

Screenshot 2023-06-18 at 20 39 03

Now pressing ? to show the built-in help, note the 2.9.0-dev version string at the top:

Screenshot 2023-06-18 at 20 39 09

Bacon was installed with:

$ cargo install --git https://github.com/Canop/bacon --rev 30f850ca0bff2cbc0c6894eaf32d27ca452a7ddf --force bacon

Bacon was run with:

$ bacon test

Environment:

  • macOS
  • WezTerm terminal (same behavior also with iTerm and the built-in Terminal.app of macOS)
  • bacon version 2.9.0-dev
  • zsh

@Canop
Copy link
Owner

Canop commented Jun 19, 2023

Bacon was installed with:

$ cargo install --git https://github.com/Canop/bacon --rev 30f850ca0bff2cbc0c6894eaf32d27ca452a7ddf --force bacon

This doesn't include the PR #140 branch which hasn't been merged yet (because it may bring regressions, so I want it to be tested before I merge it).

@miguno
Copy link
Author

miguno commented Jun 19, 2023

Ack.

I tested with the branch version:

$ cargo install --git https://github.com/Canop/bacon --rev 4d45699c5329db2ecb85ddcbbdf59829498901aa --force bacon

And here bacon test does work as expected, yay!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants