Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace directories-next with directories #4

Conversation

alexanderkjall
Copy link
Contributor

directories-next is a fork of directories, but the original directories project have overtaken and surpassed the fork

…es project have overtaken and surpassed the fork
@Canop
Copy link
Owner

Canop commented Mar 28, 2024

Can you please make a TLDR of why directories would be better, or link to one ?

@alexanderkjall
Copy link
Contributor Author

I'm in the process of packaging csv2svg for Debian, and we try to minimize the number of copied projects and dead forks.

Comparing https://github.com/xdg-rs/dirs/tree/master/directories and https://github.com/dirs-dev/directories-rs seems to indicate that directories-next no longer is developed.

It's not a big thing, I just wanted to send the patch upstream so that it doesn't become a Debian specific alternation :)

@Canop
Copy link
Owner

Canop commented Mar 28, 2024

There are a few other crates with the same functional scope. Having one considered as the most correct would be cool but might be not easy. I've received so many bug reports (not on this small tool but on broot and bacon) related to some corner cases not considered correct enough...

I'll try to make a review of the diffs.

@alexanderkjall
Copy link
Contributor Author

Thanks for taking a look, maybe there is a good reason for us to also package directories-next :)

@Canop Canop merged commit 0965066 into Canop:main Mar 30, 2024
@Canop
Copy link
Owner

Canop commented Mar 30, 2024

I failed to see any meaningful differences between projects.

As this program is quite isolated from the rest of my projects, there should be no problem, so I merged your PR.

@alexanderkjall alexanderkjall deleted the replace-directories-next-with-directories.patch branch May 1, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants