Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add package workflow #1158

Merged
merged 31 commits into from
Mar 23, 2022
Merged

Add package workflow #1158

merged 31 commits into from
Mar 23, 2022

Commits on Mar 13, 2022

  1. Configuration menu
    Copy the full SHA
    bb46724 View commit details
    Browse the repository at this point in the history
  2. [SCons/Cython] Remove Darwin prefix setting

    This line was added to fix a problem with Python 2 [1,2] in Homebrew
    circa 2015 via b979cea. That fix is no longer needed in 2022.
    
    [1]: https://web.archive.org/web/20190629053857/https://github.com/Homebrew/homebrew-python/issues/187
    [2]: https://web.archive.org/web/20200221230523/https://bugs.python.org/issue22269
    bryanwweber committed Mar 13, 2022
    Configuration menu
    Copy the full SHA
    cc71038 View commit details
    Browse the repository at this point in the history
  3. [Cython/Test] Fix a test that doesn't use work dir

    This test was writing data into the site-packages directory if the tests
    were run from an installed copy of Cantera.
    bryanwweber committed Mar 13, 2022
    Configuration menu
    Copy the full SHA
    0825134 View commit details
    Browse the repository at this point in the history
  4. [SCons] Configure macOS target version for Python

    In some cases, Python can issue a warning about incompatible ABI
    versions on macOS when Python is compiled with one target and Cantera is
    compiled with another. This change pulls the configuration value from
    Python if the full Python package is being built, if it isn't set by an
    environment variable.
    bryanwweber committed Mar 13, 2022
    Configuration menu
    Copy the full SHA
    fb7644e View commit details
    Browse the repository at this point in the history
  5. [Cython] Remove unnecessary install option

    This option was added to support Python 2/3 with Homebrew on Mac OS X.
    As Python 2 is no longer supported, this line is no longer needed.
    bryanwweber committed Mar 13, 2022
    Configuration menu
    Copy the full SHA
    7c092ef View commit details
    Browse the repository at this point in the history
  6. [Cython] Remove bdist_win installer

    The Windows binary MSI distribution is deprecated by Python. The
    replacement is wheels which are now working.
    bryanwweber committed Mar 13, 2022
    Configuration menu
    Copy the full SHA
    721a12f View commit details
    Browse the repository at this point in the history
  7. [SCons] Fix if git is not present on the system

    If git cannot be found by subprocess, it raises a FileNotFoundError.
    bryanwweber committed Mar 13, 2022
    Configuration menu
    Copy the full SHA
    e260a92 View commit details
    Browse the repository at this point in the history
  8. [SCons/Cython] Use pip to build/install interface

    Setuptools versions greater than 60.0.0 deprecate using setup.py install
    commands, in preference for PEP 517/518 build backends/frontends. In
    this case, we're using pip as the frontend and setuptools as the
    backend.
    
    This also uses pip to determine the installation location for the
    module. It uses pip's internal API which is subject to change. However,
    pip does not expose an external API to get this information, and since
    Pip is the one determining where files will be installed, this seems the
    most reasonable approach for now.
    bryanwweber committed Mar 13, 2022
    Configuration menu
    Copy the full SHA
    42f5ff0 View commit details
    Browse the repository at this point in the history
  9. [SCons/Cython] Change default python_prefix value

    When using pip as the installer, setting the default python_prefix equal
    to the prefix configuration value is no longer necessary. By removing
    this setting, we respect the decision of the Linux distro maintainers as
    to where Pip should install packages, since Pip reads this information
    from the CPython configuration. On macOS, the system Python is locked at
    2.7, so isn't supported anyways. On Windows, this was already the
    default.
    bryanwweber committed Mar 13, 2022
    Configuration menu
    Copy the full SHA
    d064147 View commit details
    Browse the repository at this point in the history
  10. [SCons] Change installation directory printout

    There are no longer any applications installed with Cantera.
    bryanwweber committed Mar 13, 2022
    Configuration menu
    Copy the full SHA
    dd2f3ed View commit details
    Browse the repository at this point in the history
  11. [SCons] Python minimal uses pip to install

    This change mirrors the one for the Cython interface. Pip is used as
    the build frontend, setuptools is used as the backend. A wheel file is
    built during the 'scons build' phase to ensure that all the machinery is
    working properly; this wheel is not used further.
    bryanwweber committed Mar 13, 2022
    Configuration menu
    Copy the full SHA
    d54c1bd View commit details
    Browse the repository at this point in the history
  12. Flake8/quotes stuff

    bryanwweber committed Mar 13, 2022
    Configuration menu
    Copy the full SHA
    95038db View commit details
    Browse the repository at this point in the history
  13. Raise an error if the submodules aren't present

    We need these here to copy the files into the sdist.
    bryanwweber committed Mar 13, 2022
    Configuration menu
    Copy the full SHA
    80151d4 View commit details
    Browse the repository at this point in the history
  14. [Test/Reactor] Relax tolerance for custom reactor

    With OpenBLAS on macOS, this test has a relative error of 1.06e-8, just
    barely exceeding the original tolerance.
    bryanwweber committed Mar 13, 2022
    Configuration menu
    Copy the full SHA
    3047394 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    4103774 View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    e552d2c View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    c090f87 View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2022

  1. [CI] Add Windows MSI job

    bryanwweber committed Mar 14, 2022
    Configuration menu
    Copy the full SHA
    a10cf62 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f8062e2 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    d3a9f79 View commit details
    Browse the repository at this point in the history
  4. [SCons] Clean up the cleaning process

    Since Python builds are done in the build directory, we don't need to
    clean up the interfaces folder anymore.
    bryanwweber committed Mar 14, 2022
    Configuration menu
    Copy the full SHA
    cd39ef2 View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2022

  1. [CI] Fix errors in CI

    We're dropping Python 3.6, Windows builds need wheel installed, and the
    GitHub Actions macOS runners are notoriously slow.
    bryanwweber committed Mar 15, 2022
    Configuration menu
    Copy the full SHA
    cfe7e2f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    65ed4a3 View commit details
    Browse the repository at this point in the history
  3. [CI] Switch Boost download to jfrog

    The Sourceforge "pilotfibre" domain has an expired SSL certificate and
    doesn't seem to be maintained anymore.
    bryanwweber committed Mar 15, 2022
    Configuration menu
    Copy the full SHA
    3c8fb4f View commit details
    Browse the repository at this point in the history
  4. Address review comments

    bryanwweber committed Mar 15, 2022
    Configuration menu
    Copy the full SHA
    16f6ed5 View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2022

  1. Configuration menu
    Copy the full SHA
    ecd8aff View commit details
    Browse the repository at this point in the history
  2. [SCons/Cython] Fix install prefix

    If the prefix is set, the Python package should be installed there.
    bryanwweber committed Mar 19, 2022
    Configuration menu
    Copy the full SHA
    cb93743 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    8e1079a View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2022

  1. [SCons] Fix build errors on Windows

    The default_prefix variable needs to always be set. This also fixes
    backslash-separated paths by replacing with forward slash. Although this
    is most likely to occur on Windows, it's not platform specific.
    bryanwweber committed Mar 20, 2022
    Configuration menu
    Copy the full SHA
    f7e40dc View commit details
    Browse the repository at this point in the history

Commits on Mar 21, 2022

  1. [SCons] Avoid normpath for prefix

    On Windows, normpath turns forward slashes into backslashes. We want to
    avoid that because paths on Windows that have backslash turn into
    escapes that break things.
    bryanwweber committed Mar 21, 2022
    Configuration menu
    Copy the full SHA
    448d7cf View commit details
    Browse the repository at this point in the history
  2. [SCons] Move prefix string replacement

    Hopefully move this after all path manipulations happen.
    bryanwweber authored Mar 21, 2022
    Configuration menu
    Copy the full SHA
    e680b8f View commit details
    Browse the repository at this point in the history