Fix CustomRate segfaults and remove CustomReaction #1332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
Codecov Report
@@ Coverage Diff @@
## main #1332 +/- ##
==========================================
- Coverage 68.03% 68.02% -0.01%
==========================================
Files 318 318
Lines 42008 41989 -19
Branches 16880 16871 -9
==========================================
- Hits 28579 28562 -17
+ Misses 11157 11155 -2
Partials 2272 2272
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
bryanwweber
reviewed
Jul 5, 2022
ischoegl
requested review from
chinahg and
a team
and removed request for
chinahg
bryanwweber
reviewed
Jul 5, 2022
10 tasks
ischoegl
force-pushed
the
fix-custom-rate
branch
from
50fd33c
to
2e3529d
Compare
ischoegl
force-pushed
the
fix-custom-rate
branch
from
2e3529d
to
c2ca5d1
Compare
|
@bryanwweber / @speth ... rebased and ready for a review. The commits are also included in #1333, so it will be easier to review this first. |
ischoegl
force-pushed
the
fix-custom-rate
branch
from
11d2af0
to
f30054a
Compare
|
@speth ... thanks for the review! I updated both instances per recommendation. |
speth
approved these changes
Jul 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
CustomReactionspecializationIf applicable, fill in the issue number this pull request is fixing
Closes #1282, partially addresses Cantera/enhancements#142
If applicable, provide an example illustrating new features this pull request is introducing
Checklist
scons build&scons test) and unit tests address code coverage