Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to PyData Sphinx theme #1573

Merged
merged 6 commits into from
Aug 9, 2023
Merged

Switch to PyData Sphinx theme #1573

merged 6 commits into from
Aug 9, 2023

Conversation

speth
Copy link
Member

@speth speth commented Aug 8, 2023

Changes proposed in this pull request

  • Switch to PyData Sphinx theme
  • Add dropdown for switching to different doc versions

If applicable, fill in the issue number this pull request is fixing

Resolves Cantera/cantera-website#210 (I think?)

If applicable, provide an example illustrating new features this pull request is introducing

image

Checklist

  • The pull request includes a clear description of this code change
  • Commit messages have short titles and reference relevant issues
  • Build passes (scons build & scons test) and unit tests address code coverage
  • Style & formatting of contributed code follows contributing guidelines
  • The pull request is ready for review

@bryanwweber
Copy link
Member

Resolves Cantera/cantera-website#210

This issue also encompasses the changes to the website side, too. Although pending the resolution of the content location, that may be less relevant.

@speth
Copy link
Member Author

speth commented Aug 8, 2023

Resolves Cantera/cantera-website#210

This issue also encompasses the changes to the website side, too. Although pending the resolution of the content location, that may be less relevant.

Yeah, I realize that there's more to it, but I kind of figure that falls under Cantera/cantera-website/issues/209, which requires picking some Sphinx theme. At least this way there's no point where we have two Sphinx sites with different themes.

@speth speth force-pushed the sphinx-pydata branch 2 times, most recently from e47f2aa to 49e9f21 Compare August 8, 2023 13:09
Copy link
Member

@ischoegl ischoegl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No objections from my side, but I don't have a complete overview about how this integrates with the website overhaul.

Copy link
Member

@bryanwweber bryanwweber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple small suggestions for further cleanup here.

doc/sphinx/conf.py Show resolved Hide resolved
.github/workflows/main.yml Outdated Show resolved Hide resolved
@speth speth merged commit 25851e7 into Cantera:main Aug 9, 2023
42 checks passed
@speth speth deleted the sphinx-pydata branch August 9, 2023 01:58
speth added a commit to Cantera/cantera-website that referenced this pull request Aug 13, 2023
New requirement introduced in Cantera/cantera#1573.

Removes dependency on KaTeX.
speth added a commit to speth/cantera-website that referenced this pull request Aug 17, 2023
New requirement introduced in Cantera/cantera#1573.

Removes dependency on KaTeX.
speth added a commit to Cantera/cantera-website that referenced this pull request Aug 22, 2023
New requirement introduced in Cantera/cantera#1573.

Removes dependency on KaTeX.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use PyData Sphinx Theme
3 participants