-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
libcantera-devel fails on Windows #20
Comments
Can you include more of the error trace? That error might be from something conda is doing, in which case, we don't have much control over it. |
Can you provide instructions on how to generate more of the error trace? Based on my reading of the log (already attached above), it appears to be that conda is trying to copy something into a path outside of conda (i.e. the original build stack). Interestingly, it doesn't attempt the same on Linux, where headers are installed in the expected location. |
I meant can you copy more of the context from that file into the post 😄 In any case, looking at the log, the error message is generated by Conda because Conda assumes that VS 2017 is present. Basically, as best I can tell, its trying to set up that command prompt to use the VS compilers. I'm not sure what to do about that, other than to ignore it and try to compile an example anyways. |
That's what my interpretation is also. I tried compiling earlier today, but got stuck when I wasn't able to locate the headers (I just got the same result in another attempt). Where should I be looking? One a separate note: the Instead, they attach headers to their site-package and provide a custom
on Windows or
on Linux |
I think the header files go in |
@bryanwweber ... thanks for the suggestion. I checked the entire conda environment, i.e. |
Nope, sounds like a bug to me! Thanks for testing 😊 |
No problem. Thanks for your efforts putting the package together! |
@bryanwweber Any updates on bringing this to windows for 2.5.0beta? I've been using |
@ischoegl No updates, and unfortunately I don't think I'll have time to get to it considering we want to try to release 2.5.0 sometime in the next month-ish and I have 4 open PRs over at Cantera/cantera 😃 Fortunately, presuming the problem is with the packaging here and not with Cantera itself, we can fix it up after release and just push out new packages without having to make a full release of Cantera. |
Understood. Yes, I believe it should be a simple fix that is independent from the main release. Also, good to hear that 2.5.0 is close (will be teaching combustion next semester so it may come just in time). |
@bryanwweber ... just wanted to see whether there’s any update here? |
No, and unfortunately the build on Windows fails altogether at the moment. Hard to find time to get a few hours in a row to work on something these days. |
Sure. I do understand ... |
Regardless, if you get to it, I'd be happy to assist - I have a windows machine on hand at the moment (not just a virtual install) and testing would be pretty straight forward. My windows toolchain works (freshly rebuilt), but I probably won't be of much help when it comes to packaging. |
Thanks @ischoegl I appreciate the offer! I'll ping you when the Windows builds are functional again. |
@ischoegl There are new Conda packages available now, if you're willing to try them out. |
Some progress (the package installs!), but still not successful. The old error is gone, but now I'm getting stuck at
Per our previous conversation, the headers should be in I.e. no headers are installed ... I used my ctapp demo to test. PS: I used a newly installed conda environment. For setup, see top of the page. |
@ischoegl Thanks for the quick turnaround. Just to confirm, the headers should be in |
I think that would be the obvious location (?) to avoid interference with other environments. Within |
Thanks @ischoegl. I will try to get to that before the release of 2.5.0 which we're really trying to push on, but since I expect this will be relatively low usage case, I might not be able to. Fortunately, we can always release new packages after 2.5.0 comes out 😄 If you want to take a look at this, feel free! |
Np. Not sure that I am familiar enough with packaging though ... |
No problem 😄 The conda packages are pretty complicated, it's taken a long time for me to get used to them. |
Yeah. Just looked at the files .. no idea what’s going on. Thanks for taking care of this for the community! |
I’m afraid so. It’s pretty neat that you can compile against cantera, but I’m not sure that people realize. |
Final comment for the time being. This is the default path within a conda environment on my system:
Paths are not case-sensitive on Windows, so what we discussed above is confirmed. |
Conda seems to organize things slightly differently on Windows and Linux, so I'm not sure that's the right path for Cantera to install its headers. On Windows, On Linux, I would hope that the macOS directory structure is more like the Linux one, but one never knows. In both cases, I have conda version 4.7.12 installed, starting from Miniconda, and I if I recall correctly, I created both of these environments in the past 6 months. |
@speth ... thank you for the comment/correction (I don't use windows often, and mostly maintain it as some of my students rely on it). So there indeed is a |
Error still persists on 2.5.0b1 (setting up a conda environment
As before, searching for |
@bryanwweber .... now that 2.5.1 is out, - 🎉!! - I’ll have another look. I don’t expect things to have changed. |
No surprises, the issue persists.
|
@bryanwweber ... I tried to piece some of this together. Looking at I'm also not sure as to where |
One thing I just realized is that even if the installation of headers were to work as envisioned, shared libraries on windows have limited use as they currently do not export C++ symbols (see discussion on Cantera/enhancements#97). Am I seeing this correctly? |
While
conda install -c cantera/label/dev libcantera-devel
works nicely on a Linux system, it fails on Windows.Steps taken on my system:
and on
conda-dev
I tried this both with and without Visual Studio (2019) environments set up. In either case, the critical error appears to be this:
Which indicates that the conda package contains remnants of a Visual 2017 Enterprise build stack. I am attaching the full logging information: libcantera-devel.log
PS: the expected location for an anaconda installation should likely be dictated by the python system path variable as returned by
sysconfig.get_paths()['include']
The text was updated successfully, but these errors were encountered: