Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add S3 upload support #249

Merged
merged 1 commit into from
Mar 31, 2024
Merged

feat: add S3 upload support #249

merged 1 commit into from
Mar 31, 2024

Conversation

Neptune650
Copy link
Contributor

/claim #248
/fixes #248

Implementation Approach

If the user provides the 4 necessary S3 arguments, the bundle will be uploaded using the AWS SDK and the external URL will be modified accordingly to match the S3 URL.

Copy link

algora-pbc bot commented Mar 25, 2024

💵 To receive payouts, sign up on Algora, link your Github account and connect with Stripe/Alipay.

Copy link

socket-security bot commented Mar 25, 2024

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@aws-sdk/client-s3@3.540.0 Transitive: environment, filesystem, network, shell +96 7.87 MB aws-sdk-bot

View full report↗︎

Copy link

sonarcloud bot commented Mar 25, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@riderx
Copy link
Collaborator

riderx commented Mar 25, 2024

Thanks a lot. That perfect !
Can you update the documentation here as well:
https://github.com/Cap-go/website/blob/main/src/content/docs/docs/tooling/cli.md

@Neptune650
Copy link
Contributor Author

Thanks a lot. That perfect ! Can you update the documentation here as well: https://github.com/Cap-go/website/blob/main/src/content/docs/docs/tooling/cli.md

Of course, here it is Cap-go/website#196

@riderx riderx merged commit 24d9d43 into Cap-go:main Mar 31, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow option to upload in custom S3
2 participants