-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added plain text extraction to the build process #93
Conversation
This reset the unwanted changed from the no_tar branch
Few comments before I forget : I would avoid using the resolver : il would simply look for xml file that are not cts. That will remove the need of parsing metadata. I'd prefer that as an option. |
Would I get the deepest node by specifying the |
|
Stopped using the resolver and replaced it with CapitainsCtsText called on an lxml _Element Added the --txt and --cites parameters to hooktest-build
Stupid. I used my local paths to load some files in the tests. That is why it failed. I will correct it and push the new version. |
I need to test the exception on the plain_text function. Also, I think I need to specify the exception more closely. But I honestly don't remember what the error was that I was trying to catch. |
I remember now. The exception I was getting was when using the resolver and there being a file mentioned in the metadata that didn't actually exist in the file system. I will remove the try, except statement and repush since I am no longer using the resolver. |
All great and nearly ready to merge except :
|
Updated the init documentation on the build class to include the new parameters (tar, txt, cites) Updated the CHANGES.txt file to reflect the addition of the plain_text function Bumped the version number to 1.1.0 Updated the setup.py to show this version
Hey ! |
I didn't add very much since the scope at this point is fairly limited. I simply added it into the flow of prose for the `.travis.yml` file for now. Once I add the `txt`, `csv`, and `json` parameters, I will add a whole section for hooktest-build.
As I said in the text for the commit:
|
You can see what the results would look like in the /text/ directory here: https://github.com/sonofmun/canonical-lat-test/tree/0.0.147