Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change VOTE TO DELEGATE SUCCESSFUL to POSTED VOTE or POSTED VOTE TRANSACTION #53

Closed
jondubois opened this issue May 3, 2021 · 1 comment

Comments

@jondubois
Copy link
Contributor

Because the blockchain accepts all transactions (including invalid ones), we should change the wording so that it doesn't mislead the user. For example, if the user has already voted for 5 people, then the vote will do nothing.

@jondubois
Copy link
Contributor Author

jondubois commented May 3, 2021

It's better to use more neutral wording throughout. The transaction is not a success until it's been added to a block and there is no guarantee until that time. For example, if the network is busy and the user offered fees which were too low, the transaction may not go through. It could just expire in the queue.

So it's better to say things like '... was posted' or '... was sent'.

@jondubois jondubois changed the title Change VOTE TO DELEGATE SUCCESSFUL to POSTED VOTE TRANSACTION Change VOTE TO DELEGATE SUCCESSFUL to POSTED VOTE May 3, 2021
@jondubois jondubois changed the title Change VOTE TO DELEGATE SUCCESSFUL to POSTED VOTE Change VOTE TO DELEGATE SUCCESSFUL to POSTED VOTE or POSTED VOTE TRANSACTION May 3, 2021
maarteNNNN added a commit that referenced this issue May 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants