Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Created a tilemap example for testing texture atlases #63

Merged
merged 2 commits into from
Nov 14, 2023
Merged

Created a tilemap example for testing texture atlases #63

merged 2 commits into from
Nov 14, 2023

Conversation

Raelr
Copy link
Contributor

@Raelr Raelr commented Nov 12, 2023 •
edited
Loading

Description

This PR adds a new example to the project that's meant to demonstrate some 2D tilemap capabilities. The idea is that this example will be a test-bed for 2D features across the project and POTENTIALLY become the foundation for an actual game.

The PR has been...

  • provided a reasonable name that is not just the branch name (e.g "Added Vulkan render delegate")
  • linked to its related issue
  • assigned a reviewer from the team
  • labelled appropriately

The code has been...

  • made mergable and free of conflicts in relation to master (according to GitHub)
  • tested in a packaged state using the package targets
  • pulled to the reviewer's machine and reasonably tested

@Raelr Raelr added the enhancement New feature or request label Nov 12, 2023
@Raelr Raelr self-assigned this Nov 12, 2023
@Raelr Raelr force-pushed the feature/tilemap-example branch 2 times, most recently from 77e111e to c703a35 Compare November 13, 2023 03:49
@Raelr Raelr linked an issue Nov 13, 2023 that may be closed by this pull request
Add a new example for 2D tilemaps #64
Closed
@Raelr Raelr requested a review from jonjondev November 13, 2023 03:57
@Raelr Raelr added render Relating to the engine's renderer build Relating to the engine's build system labels Nov 13, 2023
jonjondev
jonjondev approved these changes Nov 13, 2023
View reviewed changes
Copy link
Member

@jonjondev jonjondev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Seems like it was pretty straight forward to add.

Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
@jonjondev
Copy link
Member

Make sure to add a description to the PR explaining what the change is for.

@Raelr Raelr force-pushed the feature/tilemap-example branch 2 times, most recently from 5a9f4c6 to 5492fe3 Compare November 14, 2023 00:03
@Raelr Raelr merged commit 8f92f40 into main Nov 14, 2023
5 checks passed
@Raelr Raelr deleted the feature/tilemap-example branch November 14, 2023 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonjondev jonjondev jonjondev approved these changes

Assignees

@Raelr Raelr

Labels
build Relating to the engine's build system enhancement New feature or request render Relating to the engine's renderer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a new example for 2D tilemaps
2 participants
@Raelr @jonjondev