Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTFM command #140

Closed
wants to merge 0 commits into from
Closed

RTFM command #140

wants to merge 0 commits into from

Conversation

Coler6
Copy link
Contributor

@Coler6 Coler6 commented Apr 5, 2022

No description provided.

Copy link

@vicky5124 vicky5124 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to all the small mistakes, the pycache folder should not be part of the repository.

carberretta/extensions/meta.py Outdated Show resolved Hide resolved
carberretta/extensions/meta.py Outdated Show resolved Hide resolved
carberretta/extensions/meta.py Outdated Show resolved Hide resolved
carberretta/extensions/meta.py Outdated Show resolved Hide resolved
carberretta/extensions/meta.py Outdated Show resolved Hide resolved
carberretta/utils/rtfm.py Outdated Show resolved Hide resolved
carberretta/utils/rtfm.py Outdated Show resolved Hide resolved
carberretta/utils/rtfm.py Outdated Show resolved Hide resolved
carberretta/extensions/meta.py Outdated Show resolved Hide resolved
carberretta/utils/rtfm.py Outdated Show resolved Hide resolved
@Jonxslays
Copy link
Collaborator

Theres tons of stuff that is untyped throughout. Everything needs to be typehinted.

@parafoxia
Copy link
Member

@Coler6gamer, you'd benefit from doing pip install -r requirements-dev.txt if you haven't already, and running nox. It'll tell you what you need to change.

@IkBenOlie5
Copy link
Contributor

That would also run the linting which would find things such as bare except on line 181 of meta.py.

@parafoxia
Copy link
Member

I don't think so, unless Mypy does it or something. It's not explicitly set up to check that.

@IkBenOlie5
Copy link
Contributor

Oh, I assumed you also used flake8 for linting just like hikari, but ig not.

@parafoxia
Copy link
Member

Nah we only use it for imports atm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants