-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RTFM command #140
RTFM command #140
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In addition to all the small mistakes, the pycache folder should not be part of the repository.
Theres tons of stuff that is untyped throughout. Everything needs to be typehinted. |
@Coler6gamer, you'd benefit from doing |
That would also run the linting which would find things such as bare except on line 181 of meta.py. |
I don't think so, unless Mypy does it or something. It's not explicitly set up to check that. |
Oh, I assumed you also used flake8 for linting just like hikari, but ig not. |
Nah we only use it for imports atm. |
No description provided.