-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added dc.js support through script tag id and data attribute #51
Conversation
Is this good to use yet? I have a client using GAS who wishes to integrate DoubleClick so wondering if I can advise him to implement this method? |
Should be working. Testing welcome :) On Wed, Oct 16, 2013 at 7:03 PM, LinsBC notifications@github.com wrote:
|
Thanks Tom, Should I be warning the client that this is in beta? And if so, any ideas when it might be migrated to the main version? |
Do you believe there is a likelihood of dc.js from being blocked and to Brian KatzSr. Web Analyst, CWA
Connect with us on twitter http://twitter.com/cardinalpath, google+https://plus.google.com/108076800625872227241/posts Catch our next training in New York City Oct 14 - 18http://training.cardinalpath.com/google-adwords-analytics/new-york-city/?utm_campaign=cp-cpt&utm_source=sig-referral&utm_medium=email&utm_content=newyorkcity-2013-10-14#2013-10-14 This email, including any attachments, is for the sole use of the intended |
@LinsBC -- test it somewhere first w/ the Google Analytics Debugger (Chrome) and if pageviews fire it should be fine to be "out of beta" @BrianKatz -- I coded a shim like this before at my past employ (30M visits / day between properties). We saw less than a 0.25% drop now that adblock whitelisted the dc.js file. The fallback seemed a bit overkill for it and sometimes double loaded / generated false positives. Would not recommend it for effort/priority. |
Thanks for this! I'm excited to start using the new version, but I'm afraid I'm not familiar enough with how github works to download new version. I checked the download and releases page, and the latest version 1.11.0 isn't listed. https://github.com/CardinalPath/gas/downloads Will something be uploaded there, or do I need to do something in github to create the file(s)? Sorry I'm such a noob! |
No worries! I'm not sponsored on this project, but will upload a release candidate type package somewhere shortly and send you a link! -Tom (via phone) On Fri, Oct 18, 2013 at 10:08 AM, Darren Carter, MD
|
Thanks Tom Brian KatzSr. Web Analyst, CWA
Connect with us on twitter http://twitter.com/cardinalpath, google+https://plus.google.com/108076800625872227241/posts Catch our next training in New York City Oct 14 - 18http://training.cardinalpath.com/google-adwords-analytics/new-york-city/?utm_campaign=cp-cpt&utm_source=sig-referral&utm_medium=email&utm_content=newyorkcity-2013-10-14#2013-10-14 This email, including any attachments, is for the sole use of the intended |
Much thanks, Tom! Darren Carter NYC SEM On Fri, Oct 18, 2013 at 11:13 AM, Tom Fuertes notifications@github.comwrote:
|
* origin/develop: Outbound events are non-interactive now Allow negative event values Don't push GAS functions inside _gaq. Extra checks on the live handler, fixes issue with ie8
Tested locally and confirmed it's loading dc.js! You can download the release candidate zip at this link: https://dl.dropboxusercontent.com/u/7795606/gas-1.11.0.rc2.zip The new snippet for how to load it can be found here: https://gist.github.com/tomfuertes/7043966 For now you'll have to host your own gas.min.js somewhere until the pull request is merged and 1.11.0 is shipped to the CDN. |
Ping @DarrenCarterMD and @LinsBC -- release candidate script is zipped and linked to in the comment above |
Thanks Tom. That's very helpful and much appreciated. |
Hi, Tom, I downloaded and unzipped the files, but when I opened it in my editor zokydoky.com However, Analytics tracking stopped. When I looked at the local script, {if(!this.tracker){var How do I fix this? Darren Carter NYC SEM On Fri, Oct 18, 2013 at 12:25 PM, Tom Fuertes notifications@github.comwrote:
|
O.o Thanks and apologies! The new build system doesn't handle ascii/unicode in the same way. I deprecated/removed the offending function/code. You can download the patched release candidate below: https://dl.dropboxusercontent.com/u/7795606/gas-1.11.0.rc2.zip -- ping @LinsBC per the @DarrenCarterMD bug report above. |
Thanks for all your help, Tom! I tried the download link, and it goes to a 404 page. Can you double-check? On Wed, Oct 23, 2013 at 10:21 AM, Tom Fuertes notifications@github.comwrote:
|
@DarrenCarterMD Sorry I pasted the old link in the original comment and edited it soon thereafter, but apparently not before the notification emails went out! Try this one: https://dl.dropboxusercontent.com/u/7795606/gas-1.11.0.rc2.zip One more time for @LinsBC |
Thanks all. This is timely as I am sending the code to a client later On Thursday, 24 October 2013, Tom Fuertes wrote:
Lindsey Buckle Mob: +61 (0) 415 658428 http://linsinproduction.blogspot.com |
Hi, I've tried the new script on a few sites, and I'm having mixed success. On these two sites, it's not working. Both have the same errors from the Google Tag Manager extension in Chrome: On this site, the tag is working. There are a couple differences in Much thanks! Darren Carter NYC SEM On Wed, Oct 23, 2013 at 4:49 PM, LinsBC notifications@github.com wrote:
|
@DarrenCarterMD Sure, which urls? |
On these two sites, it's not working. Both have the same errors from the Google Tag Manager extension in Chrome: On this site, the tag is working. There are a couple differences in implementation: 1) the script is in the body and not the head. 2) I also am using a hosted version of the script and don't have it locally. Could either be part of it? Much thanks! |
The first two urls don't actually reference an online script. Change all of your current src's from The universal analytics implementation on the first one is also missing a closing </script> tag |
But the current src's do point to a local instance of the gas.min.js script. For example, http://protectsmart.net/demo/js/gas.min.js is present. Why doesn't the local implementation work? Thanks for the catching the universal tracking tag issue! |
|
That solves it all. I'll go with my hosted file. Thanks, again! |
will the 1.11.0 gas.min.js will be brought to the CDN? I can see no chnages on the main page since 1 year... |
Working on this today! Have a PR with CDNJS (cdnjs/cdnjs#2207) to get 1.11.0 out on the CDN. I'll publish the 1.11.0 tag to master once that PR goes live. Changelog Preview of 1.11.0 can be found here and/or read below: https://github.com/CardinalPath/gas/blob/17108967a02fc673ac1b27e15c370ee4b58fe122/CHANGELOG.md 1.11.0
|
1.11.0 has landed! Pull request rebased and merged into develop/master If you want to install/update, instructions can be found on the front page README |
refs pull request #33