Fixes #2. Convert exceptions to error events. #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| size = @fstatSync(fd).size | ||
| try | ||
| if options.fd == null |
There was a problem hiding this comment.
Oops.. Now I see that custom options.fd is never used, but that was my mistake.. I should probably fix that after merge
|
I updated the spacing like you wanted. I also added a note to the readme. |
|
Thank you and now last thing. Is it possible to squash all these commits please? |
|
Done. |
|
Great and thank you 👍 |
davidkudera
pushed a commit
that referenced
this pull request
Mar 8, 2014
Fixes #2. Convert exceptions to error events.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I converted the createReadStream/createWriteStream exceptions into error events to match the original Node fs module. I converted the tests to check for this. I tried to make the code look like normal CoffeeScript, but I'm pretty new to it so I may have missed something. Let me know if there's any changes you want me to make.