Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Catch DNS errors from statsd #167

Closed
strk opened this issue Mar 4, 2014 · 3 comments
Closed

Catch DNS errors from statsd #167

strk opened this issue Mar 4, 2014 · 3 comments
Labels
bug
Milestone
0.19.4

Comments

@strk
Copy link
Contributor

strk commented Mar 4, 2014

Unhandled 'error' event is still being thrown from statsd.
See #166
I guess this time we're getting it from .increment calls, which are outside of the profiler.
@strk strk added this to the 0.19.4 milestone Mar 4, 2014
@strk strk added the bug label Mar 4, 2014
@strk strk mentioned this issue Mar 4, 2014
Closed
@strk
Copy link
Contributor Author

strk commented Mar 4, 2014

\cc @javisantana

@strk strk closed this as completed in fe41b04 Mar 4, 2014
@strk
Copy link
Contributor Author

strk commented Mar 4, 2014

Doesn't fix yet !
http://stackoverflow.com/questions/4328540/how-to-catch-http-client-request-exceptions-in-node-js

@strk strk reopened this Mar 4, 2014
@strk
Copy link
Contributor Author

strk commented Mar 5, 2014

I've finally found a way to reproduce. Just setting statsd.host to an unexistent domain. Can be easily done within the testsuite. I'm on it.

See also the bug filed upstream: sivy/node-statsd#39

@strk strk closed this as completed in 643db77 Mar 5, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
0.19.4
Development

No branches or pull requests
1 participant
@strk