Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix executeModel with POST method #525

Merged
merged 3 commits into from
Nov 9, 2022
Merged

Fix executeModel with POST method #525

merged 3 commits into from
Nov 9, 2022

Conversation

Josmorsot
Copy link
Contributor

Description

Issue: #524

executeModel was not using opts. Attributes method and body were not being passed on fetch call.

Type of change

  • Fix

@Josmorsot Josmorsot requested a review from a team November 8, 2022 13:34
@Josmorsot Josmorsot mentioned this pull request Nov 8, 2022
Closed
@Josmorsot Josmorsot added the bug Something isn't working label Nov 8, 2022
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 3420000214

  • 7 of 7 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.007%) to 71.705%
Totals Coverage Status
Change from base Build 3385987105: 0.007%
Covered Lines: 1708
Relevant Lines: 2226
💛 - Coveralls

@Josmorsot Josmorsot mentioned this pull request Nov 9, 2022
Closed
@Josmorsot Josmorsot merged commit 02a5b76 into master Nov 9, 2022
@Josmorsot Josmorsot deleted the executeModel_post_method branch November 9, 2022 06:44
Josmorsot added a commit that referenced this pull request Nov 9, 2022
@Josmorsot
Fix executeModel with POST method (#525)
e8c6626
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Josmorsot @coveralls