TimeSeriesWidget: support removing series in mounted widget #863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zbigg
changed the title
zbigg
changed the title
zbigg
changed the title
Pull Request Test Coverage Report for Build 8736752044Details
💛 - Coveralls |
|
Visit the preview URL for this PR (updated for commit 6686eca): https://cartodb-fb-storybook-react-dev--pr863-bug-sc-404044-mo-9if9u372.web.app (expires Thu, 25 Apr 2024 11:06:37 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 517cc4d31d7e09cf277774e034094b67c301cd4c |
padawannn
approved these changes
Apr 18, 2024
zbigg
force-pushed
the
bug/sc-404044/monom-solutions-sl-time-series-widget-not
branch
from
f406bb2
to
6686eca
Compare
zbigg
added a commit
that referenced
this pull request
Apr 18, 2024
Merged
zbigg
added a commit
that referenced
this pull request
Apr 18, 2024
* TimeSeriesWidget: support removing series in mounted widget (#863) * pre-release changelog update * v2.5.3
zbigg
deleted the
bug/sc-404044/monom-solutions-sl-time-series-widget-not
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Shortcut: https://app.shortcut.com/cartoteam/story/404044/monom-solutions-sl-time-series-widget-not-updating-when-parameters-change
TimeseriesWidget: Pass
notMergetoReactEchartsso it doens't attempt to merge current options with old ones. This effectively allows removing series from widget instance.Background:
Eacharts/react-echarts by default merge objects passed in
setOptionsso it's not possible to remove old series with default props update mechanism. For fully state-less, reactive behavior "setOption" strategy must changed tonotMergeso no previous state lingers in echarts component instance.Ref:
Type of change
Acceptance
Create setup where series may disappear automatically. For example through data-source filtering and configure splitByCategory on same column as filtering.
Basic checklist