Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete maps warning design issues #14685

Closed
ramiroaznar opened this issue Feb 21, 2019 · 2 comments
Closed

Delete maps warning design issues #14685

ramiroaznar opened this issue Feb 21, 2019 · 2 comments

Comments

@ramiroaznar
Copy link

Context

Please explain here below what you were doing when the issue happened

Steps to Reproduce

  1. Go to your dataset dashboard
  2. Select one or more datasets used in more than 2 maps
  3. Delete them

Current Result

  • Modal warning has a bad design

delete-maps

Expected result

  • There should be space between the two rows should be fine

Browser and version

  • Google Chrome v67
@alejandraarri
Copy link
Contributor

I was fixing this issue and I have seen another problem. When you are going to delete a shared dataset a message saying that “Some users will lose access to your datasets” appears, but as there isn’t enough space in the Dialog, both head and footer overflow.

Also, the text says that the affected maps are 11 but only a maximum of three appears listed. In the related issue #4579 we can see there was a bold type for the number of affected maps that has also been lost.

How should we solve this? @kukukaka

Screenshot 2019-05-07 at 17 24 26

@elenatorro
Copy link
Contributor

Hi @alejandraarri, do you have a branch with the changes you've made? I could start from that one!

I think we can start solving this by adding pagination or scroll, I'll make a PoC until we've a better design to implement!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants