Fix missing values in sql view #13289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The _getWrappedSQL function in the query-rows-collection object replaces the * in the SELECT with the name of every desired column. Those names are obtained from the _querySchemaModel.columnsCollection object. If this object is empty no data will be returned from the query and the table will be empty. This commit adds a listener to this collection, triggering a new fetch when this collection is changed
IagoLast
changed the title
matallo
suggested changes
Dec 26, 2017
| @@ -47,7 +47,7 @@ describe('data/query-rows-collection', function () { | |||
| }); | |||
| }); | |||
|
|
|||
| describe('._initBinds', function () { | |||
| fdescribe('._initBinds', function () { | |||
IagoLast
changed the title
matallo
approved these changes
Dec 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Listen to columnsCollection changes
The _getWrappedSQL function in the query-rows-collection object replaces the * in the SELECT with the name of every desired column. Those names are obtained from the
_querySchemaModel.columnsCollection object.
If this object is empty no data will be returned from the query and the table will be empty.
This commit adds a listener to this collection, triggering a new fetch when this collection is changed
WIP