Hotfix freeze gmaps version #13562
Merged
Hotfix freeze gmaps version #13562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ready for acceptance ✨ |
…odb into hotfix-freeze-gmaps-version
|
Accepted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent deploy of a new GMaps experimental version (v3.32) behaves differently and breaks some behaviour in
carto.js.Builder is mostly safe because when requesting a previous version, it serves the stable one. Even if you ask for
3.12. it'll serve the3.30. We only have a potential problem instatic.jswhere we don't explicitly ask for one, so the most experimental one is served.This PR:
cartodb.jsto the fixed versions, both v3 and v4.v3.30. This is the version where we know it has worked for the last year at least.Possible enhancements
app_config.ymland use it throughout all.rbfiles. I didn't feel confident at all to do that change to the backend code. Feel free to jump in and do it.