Warn te user when deleting multiple analysis #14222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 16 commits
August 6, 2018 16:52
rubenmoya
force-pushed
the
d1163-delete-multiple-analysis
branch
from
9221002
to
299cea4
Compare
| @@ -354,7 +353,9 @@ module.exports = CoreView.extend({ | |||
|
|
|||
| _onDeleteClicked: function () { | |||
| if (this._canDelete()) { | |||
| this._deleteAnalysis(); | |||
| this._analysisFormsCollection.first() !== this._formModel | |||
There was a problem hiding this comment.
Without context, I'm not getting the exact meaning of this._analysisFormsCollection.first() !== this._formModel. Could we extract an explaining variable with that expression, so the delete / warning logic is clearer?
There was a problem hiding this comment.
Everything LGTM, just asked for a little clarification above
There was a problem hiding this comment.
You're right, I moved it to its own function, basically, it checks if the selected analysis node is the last one (which is the first in the collection because it's reversed)
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: https://github.com/CartoDB/design/issues/1163
Description
This PR adds a warning when the user tries to delete an analysis node which is not the last one.
Image
Acceptance
With one analysis:
With multiple analysis:
cancelremoves the warning and doesn't delete the analysisdeletedeletes the analysisExtra
This PR also implements the new infobox styles:
When a layer is hidden:
When a legend has custom HTML:
When a popup has custom HTML:
When custom CartoCSS is applied:
When the user is over limits:
