Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove monkey patches for rails 3 and ruby 2.4 #14667

Merged
merged 2 commits into from
Mar 5, 2019
Merged

Remove monkey patches for rails 3 and ruby 2.4 #14667

merged 2 commits into from
Mar 5, 2019

Conversation

ethervoid
Copy link
Contributor

This patches were added for Rails 3 and Ruby 2.4

simon-contreras-deel
simon-contreras-deel approved these changes Mar 5, 2019
View reviewed changes
Copy link
Contributor

@simon-contreras-deel simon-contreras-deel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the original commits adding the patches, it looks good if goes green

@ethervoid ethervoid merged commit c1fe93d into master Mar 5, 2019
@ethervoid ethervoid deleted the remove_monkey_patch_24 branch March 5, 2019 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simon-contreras-deel simon-contreras-deel simon-contreras-deel approved these changes

Assignees
No one assigned
Labels
do not merge yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ethervoid @simon-contreras-deel