Visualization backup service

[simon-contreras-deel]

Objectives:

• Create visualization backup service
• Create method
• Use create method in visualization model
• Restore method
• Rake using restore method: bundle exec rake cartodb:vizs:restore_visualization['XXXXX']

[gonzaloriestra]

Love the refactor! 😍

You forgot to add the new test file in Makefile, and I added some suggestions also.

[gonzaloriestra]

You still have to add the new test in Makefile 🙂

And one more thing I forgot to mention: instead of defining the service as a module, I'd do it as a regular class, as we do here for example: https://github.com/CartoDB/cartodb/blob/master/app/services/carto/overviews_service.rb

Modules are useful to provide some extra functionality to other classes, but in this case, I think a class fits better.

[javitonino]

Couple of small comments. Nice extraction to a service!

[simon-contreras-deel]

You still have to add the new test in Makefile

Done!

About converting the service into a class, it could be a class with 2 static methods but I think it would add more bureaucracy and really, the service doesn't need to be an instance (it is even better), it doesn't have properties in common, ...

Said that as you know I have an important lack of RoR and for example, in VisualizationsExportService2 we are creating a class with only 2 modules, but I don't really understand why.

[gonzaloriestra]

I agree that here we don't need to create an instance and the methods could be static, so the class is not so useful, but I don't know why there will be more bureaucracy. In fact, we could remove some includes... Anyway, it's just an opinion, both ways are valid.

Regarding VisualizationsExportService2, I guess it's a class to avoid having to include the modules. To be able to just do VisualizationsExportService2.new.import or VisualizationsExportService2.new.export.

[simon-contreras-deel]

retest this please