Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix z-index in Quick Actions dropdown #14780

Merged
merged 3 commits into from
Mar 27, 2019
Merged

Fix z-index in Quick Actions dropdown #14780

merged 3 commits into from
Mar 27, 2019

Conversation

alejandraarri
Copy link
Contributor

@alejandraarri alejandraarri commented Mar 27, 2019

We have a little issue with z-indexes. When you have a Quick Actions dropdown open and scroll the page, you can see the dropdown above the header. This is also noticeable with the sticky headers in the tables. So we’ve done a little refactor to improve the z-index management.

image

Acceptance

  • Go the Home page, open a Quick Actions dropdown in Maps list and scroll the page. Check that it positions under the header of the Maps list but above the Datasets list header.
  • Repeat the test in the Search results page
  • Check that all dropdowns (Filters, Search suggestions, User…) are correctly positioned.

@alejandraarri alejandraarri changed the title Refactor z-indexes and extract to scss variables Fix z-index in Quick Actions dropdown Mar 27, 2019
@alejandraarri alejandraarri marked this pull request as ready for review March 27, 2019 11:29
Copy link
Contributor

@csubira csubira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice renaming and good approach about the two stacking contents! :)

@csubira
Copy link
Contributor

csubira commented Mar 27, 2019

Acceptance done following the steps described above -> 🆗

@alejandraarri alejandraarri merged commit 7153d1f into master Mar 27, 2019
@alejandraarri alejandraarri deleted the nd-z-index branch March 27, 2019 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants