Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dependent visualizations to visualizations method in GET #14802

Merged
merged 6 commits into from
May 6, 2019

Conversation

jesusbotella
Copy link
Contributor

This PR adds dependent visualizations properties (dependent_visualizations and dependent visualizations_count) to datasets returned when requesting data via GET method.

This comes from a carto-python PR that adds a check when removing datasets with dependent_visualizations (CartoDB/carto-python#107).

@gonzaloriestra gonzaloriestra self-assigned this Apr 8, 2019
@gonzaloriestra
Copy link
Contributor

✔️ Acceptance OK

@gonzaloriestra gonzaloriestra removed their assignment Apr 8, 2019
@alrocar
Copy link
Contributor

alrocar commented May 6, 2019

retest this please

@alrocar
Copy link
Contributor

alrocar commented May 6, 2019

retest this please

@alrocar
Copy link
Contributor

alrocar commented May 6, 2019

Just one known issue in one test. Deploying 🚀

@alrocar alrocar merged commit db7cbeb into master May 6, 2019
@alrocar alrocar deleted the dependent-visualizations-in-get branch May 6, 2019 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants