Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix notification warning positioning issue #14920

Merged
merged 8 commits into from
Jun 3, 2019

Conversation

alejandraarri
Copy link
Contributor

@alejandraarri alejandraarri commented May 29, 2019

This PR solves 2 problems with the notification warning.

  • There is a positioning issue that provokes banners to stack one above other in the Settings pages.

Screenshot 2019-05-29 at 19 09 17

  • In the API Keys page the same message is shown in two different banners.

Screenshot 2019-05-29 at 21 50 44

Related issue

#14859

@alonsogarciapablo
Copy link
Contributor

cc: @ana-md. That banner should no longer be there, right? Thank you!

@ana-md
Copy link

ana-md commented May 30, 2019

It should appear only for the free users that are being migrated today, it appears only for the users scheduled each day (infra takes care of that). The one in staging was only a test we did to make sure everything was working, so I guess that one doesn't need to be there. @gonzalosr can you confirm this please?

@alejandraarri
Copy link
Contributor Author

Yes, but we are mixing things a little bit. Regardless of the message we are showing right now (PG11 migration) we have a warning component that we use to make important announcements to the user. The main problem here is that the same message is shown in two different banners. We are working so that the banner below does not appear when it doesn’t have to.

@gonzalosr
Copy link

@ana-md yes, the staging one doesn't need to be there anymore

@alejandraarri
Copy link
Contributor Author

But please @gonzalosr, don't remove it because I need it to test all the cases!! 🙏

@gonzalosr
Copy link

@alejandraarri Thought so! don't worry :)

@alonsogarciapablo
Copy link
Contributor

Thank you all! Keep going @alejandraarri!

@alejandraarri
Copy link
Contributor Author

Opened a new issue to fix the second error (#14936) so we can merge this PR and correct the positioning issue as it is important for the new Professional Plan release.

@alejandraarri alejandraarri marked this pull request as ready for review May 31, 2019 15:49
Copy link
Contributor

@csubira csubira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Such a great improvement!

@csubira
Copy link
Contributor

csubira commented Jun 3, 2019

Acceptance steps:

Log in as staging user (with maintenance warning banner active):

  • Check dashboard home the maintenance warning shows ok

  • Check that Sticky Header (Navbar and maps and dataset tables) are properly displayed when scrolling

  • Maps page (condensed view) and Dataset page: test sticky header of tables and bulk actions when selecting items work properly

  • Profile, account and API Keys page show maintenance banner properly (And correct margin with content below the navbar)

  • Profile/Account page: Display banner (success and error) to see that positioning for both banners is correct

Log in as staging user (with maintenance warning banner inactive):

  • Check that dashboard home shows ok

  • Check that Sticky Header (Navbar and maps and dataset tables) are properly displayed when scrolling

  • Maps page (condensed view) and Dataset page: test sticky header of tables and bulk actions when selecting items work properly

  • Profile/Account page: Display banner (success and error) to see that positioning is correct (Margin with content below is ok)

Acceptance 🆗

@alejandraarri alejandraarri merged commit 5df38e8 into master Jun 3, 2019
@alejandraarri alejandraarri deleted the fix-notification-warning branch June 3, 2019 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants