Add objectid as eligible id column by our content guesser #14965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Jun 12, 2019
ethervoid
force-pushed
the
s2077_gdb_id_imports
branch
from
0e79034
to
7d7cfdf
Compare
houndci-bot
reviewed
Jun 12, 2019
ethervoid
force-pushed
the
s2077_gdb_id_imports
branch
from
7d7cfdf
to
0163016
Compare
gonzaloriestra
approved these changes
Jun 13, 2019
|
❌ Acceptance failed I've tried to follow the STR from the original issue, but it's showing the same errors... I'm trying in staging with the user |
|
@gonzaloriestra the failure you're getting is related to GDAL not to the |
ethervoid
force-pushed
the
s2077_gdb_id_imports
branch
from
9eb7b66
to
fd2630f
Compare
|
Right, it doesn't show the same error. Let's go then! |
FileGDB files has objectid column as id column so we need to include in our list of eligibles id to be able to import GDB using content guesser
ethervoid
force-pushed
the
s2077_gdb_id_imports
branch
from
fd2630f
to
2df31f9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related https://github.com/CartoDB/support/issues/2077
We have some whitelisted columns the prevails after ogr2ogr imports the file: ogc_fid, gid and cartodb_id but when we included GDB files in our catalog we didn't include its own column objectid.
Objectid is the id column for that type of files and is taken by ogr2ogr as the id column so in the fix I've made, we now include it as ID column and we use it as our cartodb_id when the content guesser is activated