Add new parameters to send via GTM #15021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib/assets/javascripts/dashboard/components/vendor-scripts/vendor-scripts-view.js
Show resolved
Hide resolved
There was a problem hiding this comment.
Left some minor comments. Other than that. It looks 👍 to me. Thank you @cillas!
|
@alonsogarciapablo Deployed in a dedicated instance, check it out here |
|
I missed this @cillas, sorry! Please go ahead and deploy it if you feel it's working 👌. Thank you! |
|
Thank you @csubira! 👏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/CartoDB/product/issues/407
This PR adds:
String)Boolean)to GTM data sent to Google Analytics.