Send all allowed params from the viz API to the viz presenter #15349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 26, 2019 20:17
update NEWS.md tt
alrocar
force-pushed
the
2291_support
branch
from
a911d73
to
1b2effa
Compare
honor review
alrocar
force-pushed
the
2291_support
branch
from
c6ba7c1
to
4e9cc53
Compare
|
retest this please |
|
✔️ Acceptance OK |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to https://github.com/CartoDB/support/issues/2291
I checked we were counting the number of
likesfor every visualization because it wasn't taking into account theshow_likes=falseparameters. At the same time I improved a little bit the method to build the options for the VisualizationPresenter which in the end turns out it's not just a presenter but it does queries to the database 🤷♂