Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude table permissions from /viz when show_permission=false #15368

Merged
merged 2 commits into from
Jan 3, 2020
Merged

Exclude table permissions from /viz when show_permission=false #15368

merged 2 commits into from
Jan 3, 2020

Conversation

gonzaloriestra
Copy link
Contributor

Related to https://github.com/CartoDB/support/issues/2291

When calling to api/v1/viz with show_permission=false, it now excludes both permissions from visualizations and related tables.

alejandraarri
alejandraarri approved these changes Jan 3, 2020
View reviewed changes
Copy link
Contributor

@alejandraarri alejandraarri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✨

@gonzaloriestra
Copy link
Contributor Author

Tested in staging that the flag works as expected and everything seems to work fine 🚀

@gonzaloriestra gonzaloriestra merged commit a77ac84 into master Jan 3, 2020
@gonzaloriestra gonzaloriestra deleted the propagate-show-permissions branch January 3, 2020 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alejandraarri alejandraarri alejandraarri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gonzaloriestra @alejandraarri