Security fixes #15411
Merged
Security fixes #15411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jesusbotella
force-pushed
the
6178-security-fixes
branch
from
691ff69
to
809288c
Compare
elenatorro
suggested changes
Jan 24, 2020
elenatorro
approved these changes
Jan 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements two security fixes:
Disable autocomplete for password fields
Add
rel="noopener noreferrer"to all links using thetarget="_blank"We don't have so many third-party links, but as Lighthouse considers different subdomains as 3rd party hosts, we need to add
relattribute to make sure we pass that rule across user domains. https://developers.google.com/web/tools/lighthouse/audits/noopener