Rtorre/ch57809/rui store bq and gcs user settings in redis #15453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gonzaloriestra
suggested changes
Feb 3, 2020
added 19 commits
February 4, 2020 13:25
This time for real.
As per review: - added before and after to create and cleanup fixtures - split into several tests - improved assertions
Changes here: - No attr_reader but an array of REDIS_KEYS - Do not check attributes on initialization but on output to redis - Use slice and merge for more compact solution - Make private what doesn't need visibility from outside
rafatower
force-pushed
the
rtorre/ch57809/rui-store-bq-and-gcs-user-settings-in-redis
branch
from
8f2876c
to
65543ea
Compare
rafatower
deleted the
rtorre/ch57809/rui-store-bq-and-gcs-user-settings-in-redis
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pretty much the design we talked about:
central -> rui -> redis <- do.It doesn't break much of the existing code (see limits for instance)
The plan is to make Central synchronize updates by adding
gcloud_accounttoATTRIBUTES_FOR_CLOUDso that it can enjoy the facilities there (with a little bit of massaging? otherwise I'll make an explicit call with the attributes we're interested in).FTM I excluded the
instant_licensingflag synchronization, which would complicate matters unnecessarily at this point.