Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve analysis joins performance in Builder UI #15454

Merged
merged 14 commits into from
Feb 4, 2020

Conversation

elenatorro
Copy link
Contributor

@elenatorro elenatorro commented Feb 3, 2020

Related issue: https://github.com/CartoDB/support/issues/2291

Acceptance steps

  1. Create a new user in staging
  2. Add +70 datasets
  3. Create a map from one of the datasets
  4. Go to edit the map
  5. Add a "Add Columns from 2nd Dataset" Analysis
  6. Check how much time the target dropdown list takes to load
  7. Select a target and add the analysis
  8. Check the analysis works properly

@elenatorro
Copy link
Contributor Author

I've done a second acceptance round with different geometries and it works as expected (it disables the analysis that can't be applied depending on the geometry)

In my opinion, I think we can merge it 👍

Copy link
Contributor

@alejandraarri alejandraarri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✨

@elenatorro elenatorro merged commit a3db4aa into master Feb 4, 2020
@elenatorro elenatorro deleted the 2291-support-target-join-analysis branch February 4, 2020 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants