Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR caused the dashboard to show an error:
The error raises here:
cartodb/lib/assets/javascripts/new-dashboard/core/trackers.js
Line 26 in 1465b27
And the problem is that
show_trial_reminder?
was returning null sometimes. The fix consists in making the method to always return true or false.To ensure it works, we have to enable track.js for Staging (in
app_config.yml
).