Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix show_trial_reminder? #15477

Merged
merged 1 commit into from
Feb 12, 2020
Merged

Fix show_trial_reminder? #15477

merged 1 commit into from
Feb 12, 2020

Conversation

gonzaloriestra
Copy link
Contributor

This PR caused the dashboard to show an error:

Screenshot 2020-02-12 at 14 43 55

The error raises here:

userInTrialPeriod: store.state.user.show_trial_reminder.toString()

And the problem is that show_trial_reminder? was returning null sometimes. The fix consists in making the method to always return true or false.

To ensure it works, we have to enable track.js for Staging (in app_config.yml).

@gonzaloriestra
Copy link
Contributor Author

✔️ Acceptance OK

  • Reproduced the issue in staging by enabling Track.js
  • Applied the fix and checked that it works

@gonzaloriestra gonzaloriestra merged commit 8f44846 into master Feb 12, 2020
@gonzaloriestra gonzaloriestra deleted the fix-show-trial-reminder branch February 12, 2020 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants