Lazy loading for routes and webpack optimizations #15581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib/assets/javascripts/new-dashboard/router/routes/connected_apps.js
Outdated
Show resolved
Hide resolved
…artoDB/cartodb into lazyload-webpack-optimizations
jesusbotella
force-pushed
the
lazyload-webpack-optimizations
branch
from
56459a8
to
11acc50
Compare
jesusbotella
force-pushed
the
lazyload-webpack-optimizations
branch
from
c4c428c
to
3a0c278
Compare
package.json
Outdated
| "babel-preset-env": "^1.7.0", | ||
| "babel-preset-es2015": "6.24.1", | ||
| "babel-preset-stage-2": "^6.24.1", | ||
| "@babel/plugin-syntax-jsx": "^7.8.3", |
| } | ||
| ] | ||
| ], | ||
| "sourceType": "unambiguous", |
There was a problem hiding this comment.
Any particular problem found before this sourceType setting or it is just "recommended"?
There was a problem hiding this comment.
We need to set it to unambiguous because we mix different module formats.
| @@ -28,6 +29,8 @@ module.exports = { | |||
| }, | |||
| devtool: 'source-map', | |||
| plugins: [ | |||
| new webpack.ContextReplacementPlugin(/moment[/\\]locale$/, /en/), | |||
There was a problem hiding this comment.
Nice addition, I guess we're saving some bytes there...
|
@jesusbotella Really nice job here. Thx for the effort on updates and improvements |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While configuring a new route for Direct DB connection page (not in this branch), I saw that there were so many routes within the same file. So, I split them into several files and leveraged the opportunity to add lazy loading to all of the page components.
Kinda related to #14606