Restore twitter connector #15656
Merged
Restore twitter connector #15656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VictorVelarde
force-pushed
the
fix/restore-twitter-connector
branch
from
5bd36d3
to
1f6fc0f
Compare
jesusbotella
reviewed
May 8, 2020
| enabled: function (config, userData) { | ||
| return userData.get('twitter').enabled && !!config.get('datasource_search_twitter'); | ||
| enabled: function (_, userData) { | ||
| return userData.get('twitter').enabled; |
There was a problem hiding this comment.
This is for editor, but I guess that it's good to have consistent code 😁
| if (!this._configModel.get('datasource_search_twitter') || | ||
| !this._userModel.get('twitter').enabled || | ||
| !this._userModel.canCreateTwitterDataset()) { | ||
| if (!this._userModel.get('twitter').enabled) { |
There was a problem hiding this comment.
I guess we could just return this._userModel.get('twitter').enabled.
There was a problem hiding this comment.
👌 I removed conditions and I didn't notice it
…ntials, not quota
VictorVelarde
force-pushed
the
fix/restore-twitter-connector
branch
from
1f6fc0f
to
2c8773f
Compare
|
Thx for the comments @jesusbotella Yeah, the date picker appeared broken, like this: I've applied your suggestions 🔝 |
jesusbotella
approved these changes
May 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restore twitter connector for those who manage their own credentials
Steps for acceptance
You will see: