Bring profiler to 2020 #15691
Merged
Bring profiler to 2020 #15691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. I'm building this locally to test, but I understand that if I do a request with the Pinging @alasarr since we was also thinking on using this and it might be really useful now. |
Algunenano
suggested changes
Jun 1, 2020
Since the callgrind traces are sent in the body of the request, there's no need to create a directory to save callgrind traces in the filesystem. Remove code that created that directory and failed if the parent did not exist, producing a 500 error.
good catch, fixing it straight away! |
Algunenano
approved these changes
Jun 1, 2020
|
PS: wiki page updated as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple of light touches to the best tool under my belt to profile slow ruby code.
Amazed it almost worked out of the box 5 years later.
The biggest change is returning the profile trace as the request payload, instead of making you look it up in rui servers in production.
See this wiki page (I know, update pending): https://github.com/CartoDB/cartodb-management/wiki/Profiling-rails
cc/ @CartoDB/backend-team FWIW
have a nice 🐸 time!