Could not create dataset from query #15765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
July 27, 2020 19:09
Do not treat data sources of type query as files or URI's when we know for sure they are SQL queries. This avoids problems such as errors parsing (some_sql_expression)::some_cast as a URI.
There are circumstances in which there's a query but the data_type is not set. I think it can only happen in tests (not coming from the controller) but just in case, let's make the code safer.
rafatower
changed the title
rafatower
deleted the
bug/ch79725/ibicarto1-could-not-create-dataset-from-query
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Story details: https://app.clubhouse.io/cartoteam/story/79725