api/v4/datasets doesn't return all shared datasets

[alasarr]

Story details: https://app.clubhouse.io/cartoteam/story/95768

It includes the datasets shared with the org and the datasets shared with any group the user belongs to

[manmorjim]

LGTM 👍

[amiedes]

I feel a more robust way of fixing this would be to extract the query-related logic out of the controller, and then write unit tests for it. Moving this kind of logic out of the controllers has as benefit that writing tests for it without worrying about session and request cycle is much easier 💅 .

As an example, you can see it's done that way for Carto::VisualizationQueryBuilder.

Since there's a meeting this afternoon with the client, and this suggestion implies a refactor, I leave to you the decision of tackling this now or not 🙂

[alasarr]

Agree @amiedes, in fact, I see similar queries in other places like user_db_service.db. However, I didn't want to start a refactor for a bug, but I'll add this refactor to the backlog.