Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/ch83448/fix map backups with ghost tables #15832

Merged
merged 3 commits into from
Sep 16, 2020

Conversation

amiedes
Copy link
Contributor

@amiedes amiedes commented Sep 15, 2020

Closes https://app.clubhouse.io/cartoteam/story/83448/fix-map-backups-with-ghost-tables

Fixes maps backups when deleting user tables via Ghost Tables

@amiedes amiedes force-pushed the bug/ch83448/fix-map-backups-with-ghost-tables branch 2 times, most recently from 9bfc446 to fc9b840 Compare September 15, 2020 09:43
@amiedes amiedes marked this pull request as ready for review September 15, 2020 10:31
Copy link
Contributor

@rafatower rafatower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👏 👏

In the end It was different from what I had in mind (partly because of my bad memory).

app/helpers/logger_helper.rb Show resolved Hide resolved
@amiedes amiedes force-pushed the bug/ch83448/fix-map-backups-with-ghost-tables branch from fc9b840 to 891614b Compare September 16, 2020 14:27
@amiedes
Copy link
Contributor Author

amiedes commented Sep 16, 2020

Acceptance ✅ : I dropped the cartodb_id column of a dataset in staging and I was able to find and restore the backup.

@amiedes amiedes merged commit 58dacae into master Sep 16, 2020
@amiedes amiedes deleted the bug/ch83448/fix-map-backups-with-ghost-tables branch September 16, 2020 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants