Migrate OauthToken from Sequel to AR #15840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafatower
approved these changes
Sep 17, 2020
| add_association_dependencies :oauth_tokens => :destroy | ||
| def tokens | ||
| Carto::OauthToken.where(client_application_id: id) | ||
| end |
There was a problem hiding this comment.
👏 👏 on cutting those associations.
Probably ClientApplication should be the next one to target.
| @@ -0,0 +1,386 @@ | |||
| class UserMetadataExportFactory | |||
|
|
|||
| def self.full_export(params = {}) | |||
| client_application = carto_user.client_application | ||
|
|
||
| access_token = Carto::AccessToken.create(:user => carto_user, :client_application => client_application) | ||
| access_token.present? |
There was a problem hiding this comment.
minor thing: I think the test does nothing if it is nil (it will fail later) unless you write something like expect(access_token.present?).to be true
The oob? method is used from the gem, and the name of the tokens association is also hardcoded there
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Story details: https://app.clubhouse.io/cartoteam/story/104097
What does this PR do?
Migrates
::OauthToken,::AccessTokenand::RequestTokenfromSequeltoActiveRecordMain issues faced
Check https://app.clubhouse.io/cartoteam/story/104097/migrate-oauthtoken-from-sequel-to-ar#activity-105485